Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Add more command to view list of tables for the vms database if existing one fails #1076

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Aaishpra
Copy link
Member

@Aaishpra Aaishpra commented Sep 2, 2020

Description

Adding \dt[S+] command in installation guide if existing one fails
Fixes #1040

Type of Change:

  • Documentation

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

@Aaishpra
Copy link
Member Author

Aaishpra commented Sep 2, 2020

@ajitesh13 please review the PR.

Copy link

@ajitesh13 ajitesh13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Aaishpra
Copy link
Member Author

Aaishpra commented Sep 4, 2020

@ajitesh13 can u tell me is the pr is ready to merge or any review or any change is needed.

@ajitesh13
Copy link

@Aaishpra This PR is ready to merge as I have given my approval, next step would be merging this PR who have the write access to this repository.

@Aaishpra
Copy link
Member Author

Aaishpra commented Sep 5, 2020

Okay

@isabelcosta isabelcosta added the Status: Needs Review PR needs an additional review or a maintainer's review. label Sep 12, 2020
@Aaishpra
Copy link
Member Author

@keshakaneria can you review this? This has been sitting here from a long time now .

Copy link
Member

@keshakaneria keshakaneria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, the other condition which was left is added!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: Needs Review PR needs an additional review or a maintainer's review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more command to view list of tables for the vms database if existing one fails
4 participants